Skip to content

Android: honor a port in the metro.host system property #58585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janicduplessis wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Android: honor a port in the metro.host system property #58585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...ve/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/AndroidInfoHelpers.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,14 @@ public object AndroidInfoHelpers {
context.resources.getInteger(R.integer.react_native_dev_server_port)

private fun getServerIpAddress(context: Context?, port: Int): String {
val metroHost = getMetroHostPropValue()
// A "host:port" value names the port too, like RCT_jsLocation on iOS.
if (metroHost.contains(':')) {
return metroHost
}
val ipAddress: String =
when {
getMetroHostPropValue().isNotEmpty() -> getMetroHostPropValue()
metroHost.isNotEmpty() -> metroHost
isRunningOnGenymotion() -> GENYMOTION_LOCALHOST
isRunningOnStockEmulator() -> EMULATOR_LOCALHOST
else -> DEVICE_LOCALHOST
Expand Down
Loading