Skip to content

Fix Exception in list static filter index assumptions#1120

Open
jcummings2 wants to merge 9 commits into
reactivemarbles:mainfrom
jcummings2:fix-removekey-list-static-filter-index-assumptions
Open

Fix Exception in list static filter index assumptions#1120
jcummings2 wants to merge 9 commits into
reactivemarbles:mainfrom
jcummings2:fix-removekey-list-static-filter-index-assumptions

Conversation

@jcummings2

Copy link
Copy Markdown
Contributor

See #1119

Comment thread src/DynamicData.Tests/Cache/RemoveKeyFixture.cs Outdated
Comment thread src/DynamicData.Tests/Cache/RemoveKeyFixture.cs
Comment thread src/DynamicData/List/Internal/Filter.Static.cs Outdated
Comment thread src/DynamicData/List/Internal/Filter.Static.cs
@jcummings2

Copy link
Copy Markdown
Contributor Author

I updated test names and removed the extraneous comment per your feedback. Let me know if those names need further tweaking.

I also added another test that moves the RemoveKey() call to just before the bind. This new test passes even with the old code as it turns out.

@JakenVeina JakenVeina force-pushed the fix-removekey-list-static-filter-index-assumptions branch from c3967e0 to 7d02d18 Compare July 2, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants