Fix isExpanded check in SidebarButton - #8638
Open
mdimamhosen wants to merge 1 commit into
Open
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
SidebarButton.tsx, the expansion chevron arrow condition was checking:{typeof isExpanded && !heading && (In JavaScript,
typeof isExpandedevaluates to'boolean'or'undefined'. Since non-empty strings are truthy in JS (Boolean("undefined") === true), the arrow was rendered even whenisExpandedwas undefined / not provided.This PR updates the condition to
{isExpanded != null && !heading && (, matching the pattern used inSidebarLink.tsx.Verification
yarn tscpassed (0 errors)yarn prettier:diffpassednpx next lintpassedyarn test:eslint-local-rulespassed