Skip to content

topnav: add login modal#398

Draft
ericholscher wants to merge 4 commits into
mainfrom
claude/create-login-modal-hHyKK
Draft

topnav: add login modal#398
ericholscher wants to merge 4 commits into
mainfrom
claude/create-login-modal-hHyKK

Conversation

@ericholscher
Copy link
Copy Markdown
Member

@ericholscher ericholscher commented Apr 23, 2026

Adds a #login-modal in topnav.html mirroring the existing sign-up modal, giving Community and Business options that link to the respective dashboards. The modal opens via the #login hash, which showModalsByHash() already maps. The topnav Log in dropdown and Sign up button are unchanged.

Copy is written for returning users (not decision-making for new users): intro "Log in to the site where your account is registered", one-line platform reminders, and actions "Not sure which site?" / "Don't have an account? Sign up".

Screenshot

Login modal

Screenshot is committed under .github/screenshots/ for review. Remove before merge if preferred. (Font Awesome Pro icons don't render in the local build, so the card headers appear text-only here; they'll appear with icons in production.)


Generated by AI

@humitos
Copy link
Copy Markdown
Member

humitos commented Apr 23, 2026

Why this PR is not getting the comment from the app? I was looking the link to click and test it. Don't we have it configured on this repository?

@humitos
Copy link
Copy Markdown
Member

humitos commented Apr 23, 2026

It looks like this 👍🏼

Screenshot_2026-04-23_15-45-01

@humitos
Copy link
Copy Markdown
Member

humitos commented Apr 23, 2026

By the way, I would change the "Login" link to show this modal instead of the dropdown to unify everything. When clicking this link it should show the modal.

Screenshot_2026-04-23_15-45-52

@ericholscher
Copy link
Copy Markdown
Member Author

Yea, I didn't update the link to just try it out as a link from the docs first. Wasn't sure the right approach.

@humitos
Copy link
Copy Markdown
Member

humitos commented May 7, 2026

It would be good to move forward with this PR so we standardize these buttons 👍🏼

@ericholscher
Copy link
Copy Markdown
Member Author

Honestly I'd like to fully remove the modals and just link to specific pages I think. Modals are a pretty bad UX in my experience, especially with these with hash issues, I'd love to just be able to build these as normal pages that can be linked to like normal :)

@ericholscher ericholscher requested review from agjohnson and humitos May 8, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants