topnav: add login modal#398
Draft
ericholscher wants to merge 4 commits into
Draft
Conversation
Member
|
Why this PR is not getting the comment from the app? I was looking the link to click and test it. Don't we have it configured on this repository? |
Member
Member
Member
Author
|
Yea, I didn't update the link to just try it out as a link from the docs first. Wasn't sure the right approach. |
Member
|
It would be good to move forward with this PR so we standardize these buttons 👍🏼 |
Member
Author
|
Honestly I'd like to fully remove the modals and just link to specific pages I think. Modals are a pretty bad UX in my experience, especially with these with hash issues, I'd love to just be able to build these as normal pages that can be linked to like normal :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adds a
#login-modalintopnav.htmlmirroring the existing sign-up modal, giving Community and Business options that link to the respective dashboards. The modal opens via the#loginhash, whichshowModalsByHash()already maps. The topnav Log in dropdown and Sign up button are unchanged.Copy is written for returning users (not decision-making for new users): intro "Log in to the site where your account is registered", one-line platform reminders, and actions "Not sure which site?" / "Don't have an account? Sign up".
Screenshot
Generated by AI