Skip to content

Support SwiftLint on Windows#6636

Open
SimplyDanny wants to merge 13 commits into
mainfrom
windows-support-merge
Open

Support SwiftLint on Windows#6636
SimplyDanny wants to merge 13 commits into
mainfrom
windows-support-merge

Conversation

@SimplyDanny
Copy link
Copy Markdown
Collaborator

@SimplyDanny SimplyDanny commented May 14, 2026

Resolves #6351.
Resolves #6352.

Resolves #6349.

@SimplyDanny SimplyDanny force-pushed the windows-support-merge branch from b9a61cc to a8a34b8 Compare May 14, 2026 18:02
@SwiftLintBot
Copy link
Copy Markdown

SwiftLintBot commented May 14, 2026

1 Warning
⚠️ Big PR
19 Messages
📖 Building this branch resulted in a binary size of 27687.65 KiB vs 27639.02 KiB when built on main (0% larger).
📖 Linting Aerial with this PR took 0.84 s vs 0.8 s on main (4% slower).
📖 Linting Alamofire with this PR took 1.13 s vs 1.09 s on main (3% slower).
📖 Linting Brave with this PR took 7.53 s vs 7.42 s on main (1% slower).
📖 Linting DuckDuckGo with this PR took 30.36 s vs 29.9 s on main (1% slower).
📖 Linting Firefox with this PR took 12.85 s vs 12.69 s on main (1% slower).
📖 Linting Kickstarter with this PR took 8.78 s vs 8.67 s on main (1% slower).
📖 Linting Moya with this PR took 0.49 s vs 0.45 s on main (8% slower).
📖 Linting NetNewsWire with this PR took 2.94 s vs 2.93 s on main (0% slower).
📖 Linting Nimble with this PR took 0.73 s vs 0.69 s on main (5% slower).
📖 Linting PocketCasts with this PR took 8.44 s vs 8.15 s on main (3% slower).
📖 Linting Quick with this PR took 0.45 s vs 0.47 s on main (4% faster).
📖 Linting Realm with this PR took 3.12 s vs 2.98 s on main (4% slower).
📖 Linting Sourcery with this PR took 1.93 s vs 1.92 s on main (0% slower).
📖 Linting Swift with this PR took 4.9 s vs 4.82 s on main (1% slower).
📖 Linting SwiftLintPerformanceTests with this PR took 0.48 s vs 0.35 s on main (37% slower).
📖 Linting VLC with this PR took 1.32 s vs 1.28 s on main (3% slower).
📖 Linting Wire with this PR took 19.66 s vs 19.32 s on main (1% slower).
📖 Linting WordPress with this PR took 13.3 s vs 13.08 s on main (1% slower).

Generated by 🚫 Danger

@SimplyDanny SimplyDanny changed the base branch from main to update-swift-xcode May 14, 2026 18:04
Base automatically changed from update-swift-xcode to main May 14, 2026 18:21
@SimplyDanny SimplyDanny marked this pull request as ready for review May 14, 2026 18:21
compnerd and others added 13 commits May 16, 2026 08:22
An assortment of fixes that improve the test coverage on Windows. With
this set, local testing reveals 1 failure (RemoteCycleDetection) and
another set of test failures due to Windows globbing not matching the
POSIX semantics.

Co-authored-by: Roman Lavrov <roman.lavrov@thebrowser.company>
# Conflicts:
#	Source/SwiftLintFramework/Extensions/FileManager+SwiftLint.swift
#	Tests/IntegrationTests/ConfigPathResolutionTests.swift
@SimplyDanny SimplyDanny force-pushed the windows-support-merge branch from a8a34b8 to 7dcb76c Compare May 16, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix all tests failing on Windows Fix Glob filtering for included/excluded paths on Windows Windows Support

3 participants