fix(missing_docs): lint members when excluding inherited types#6644
Open
leno23 wants to merge 1 commit into
Open
fix(missing_docs): lint members when excluding inherited types#6644leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Stop skipping all members inside types that inherit from a protocol when `excludes_inherited_types` is enabled. Only the type declaration itself is excluded from documentation requirements. Fixes realm#5633
Generated by 🚫 Danger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
excludes_inherited_typeswas enabled, SwiftLint skipped the entire body of types that conform to a protocol. That prevented legitimatemissing_docsviolations on non-inherited members.This change only excludes the type declaration itself and continues linting members inside the type.
Fixes #5633
Test plan
IdentifiableconformanceMade with Cursor