fix(config): fall back when nested YAML is invalid#6647
Open
leno23 wants to merge 2 commits into
Open
Conversation
Use default configuration when auto-discovered nested .swiftlint.yml files cannot be parsed, matching behavior when linting from that directory. Fixes realm#6052
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.swiftlint.ymlwhile grouping files by directory, invalid YAML (e.g. duplicate keys) now warns and falls back to the default configuration instead of callingabort().Issue.errorDescriptionforyamlParsingso the YAML parse message is surfaced correctly.Fixes #6052
Test plan
testNestedConfigurationWithInvalidYamlFallsBackToDefaultwith a fixture mirroring the issue report (duplicateopt_in_rulesinsubdir/.swiftlint.yml).Notes
This complements the existing error-reporting improvement for #6052 on
main; it specifically fixes the crash when linting from a parent directory with an invalid nested config.Made with Cursor