fix(attributes): apply arguments-on-new-line to types and functions#6652
Open
leno23 wants to merge 1 commit into
Open
fix(attributes): apply arguments-on-new-line to types and functions#6652leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
When `attributes_with_arguments_always_on_line_above` is enabled, functions and types now allow argument-less attributes on the same line while requiring attributes with arguments on a separate line. Fixes realm#5011
Generated by 🚫 Danger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attributes_with_arguments_always_on_line_aboveis enabled (default), functions and types now follow the same rule as variables and imports: attributes without arguments may appear on the same line, while attributes with arguments must be on a separate line.Fixes #5011
Test plan
@objc(Foo)/@objcon classes and functions@objc(Foo)on the same line as declarationsMade with Cursor