fix: accessibility_trait_for_button with #available traits#6653
Open
leno23 wants to merge 1 commit into
Open
Conversation
Recognize .isButton and .isLink inside closure bodies and if expressions passed to accessibilityAddTraits, including immediately invoked closures with if #available branches. Fixes realm#6446
Generated by 🚫 Danger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6446. The rule did not treat
.isButton/.isLinkas present when passed via an immediately invoked closure orif #availablebranches inaccessibilityAddTraits.Changes
IfExprSyntaxbranches when checking traitsTest plan
swift test --filter AccessibilityTraitForButtonRuleGeneratedTestsMade with Cursor