fix: vertical_whitespace_between_cases ignores comment separators#6654
Open
leno23 wants to merge 1 commit into
Open
fix: vertical_whitespace_between_cases ignores comment separators#6654leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Do not require a blank line between one-line switch cases when only comments or empty lines appear between them. Fixes realm#6412
Generated by 🚫 Danger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6412. Since 0.63,
vertical_whitespace_between_casesrequired a blank line before inline comments between switch cases even when both cases are one-liners on adjacent logical groups.Changes
Test plan
swift test --filter VerticalWhitespaceBetweenCasesRuleGeneratedTestsMade with Cursor