fuzz: agree when cmpct getblocktxn is a subset - #681
Merged
Merged
Conversation
018 already treats an extra missing index as our lack of Core's extra-txn ring. The check only allowed recipe [1, 4] vs [1], so nightly ours [2, 4] vs Core [2] still panicked. Any Core index list contained in ours agrees; a Core index we did not request still fails.
rearden-grok
Bot
force-pushed
the
fuzz/cmpct-extra-ours
branch
from
September 22, 2026 14:16
527d337 to
0613084
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmpct_getblocktxn_agreeswas documented as “Core’s indexes are a subset of ours” (018: we stillgetblocktxna duplicate-txid slot Core’s extra-txn already filled). The code only allowed the one recipe[1, 4]vs[1].Nightly
cmpct_differentialpanicked on[0, 251, 229, 55, 51, 13, 10]: ours[2, 4], Core[2]. Same shape, different indexes. Any Core list contained in ours now agrees. A Core index we did not request still fails.Test plan
cargo test --manifest-path fuzz/Cargo.toml --lib overnight