store: drop unreachable Paged SH and the BDZ1 codec - #682
Merged
Merged
Conversation
Mode-10 scripthash heads already refuse in unpack8, so the Paged value and the walks only it used are gone. BDZ1 was a test codec; tx.head is BDZ2 and sealed SH heads are BDZ3. KIND_IDX was unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShHeadValue::Paged. Pack8 mode 2 still refuses (INDEX_REFUSE_PAGED_SH). Extent keepsappend_fks_to_pagesandcollect_page_chain_linked.BDZ1codec (BdzMphf::write_to/read_from).tx.headstays packed BDZ2. Sealed scripthash heads stay BDZ3.KIND_IDX.finalize_sh_runsdescribes the two-scan extract. A short SHAL header no longer says "run migrate".docs/personal-node-plans/is unchanged.Test plan
cargo test -p rbitcoin-store --lib -- scripthash bdz tx_head pack_udcargo clippy -p rbitcoin-store --all-targets -- -D warningscargo clippy -p rbitcoin-query --lib -- -D warnings