Skip to content

docs: Commands ブロックに yarn lint:overrides を載せる - #70

Merged
isamu merged 1 commit into
mainfrom
docs/lint-overrides-command
Aug 27, 2026
Merged

docs: Commands ブロックに yarn lint:overrides を載せる#70
isamu merged 1 commit into
mainfrom
docs/lint-overrides-command

Conversation

@isamu

@isamu isamu commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

PR #67 で意図的に後回しにしていた 1 行を入れます。#65 が CLAUDE.md の同じ Commands ブロックを編集していたため、予測できるコンフリクトを避けて #65 のマージ後に回していたものです(#67 の本文と ledger の row 0c に記録済み)。両方マージ済みになったので回収します。

Items to Confirm / Review

所要時間を書きかけて、実測したら嘘でした。 最初は「~40s」と書きました —— #67 のブランチでの実測値です。今 main で測ると 11 秒でした。

理由は #68 が同じ config を変えたからです:

免除の数 所要
#67 のブランチ 19 41 秒
マージ後の main 14 11 秒

#68strict-boolean-expressions を解消し(1 件)、max-lines / max-lines-per-function の 4 エントリを warn から天井付き error(=免除ではなくゲート)に変えたので、計 5 つが測定対象から外れました。2 つの PR が意図どおり噛み合った結果で、この検査が config を追随していることの実証でもあります。

そのうえで、config 次第で動く数は書かないことにしました。数をコメントに書いて腐らせるのは、まさに lint:overrides が見つけて回っていた腐り方です。「免除 1 つにつき lint 1 回」という形だけを書いています。

裏取り

  • CLAUDE.md / README / ci.yml が語る yarn <script>package.json と突き合わせ → 実在しない script は無しどこにも書かれていない script も無し
  • format:check / lint / typecheck / test すべて終了コード 0

User Prompt

Summary by Sourcery

Document the deferred yarn lint:overrides command in the project’s development command reference.

Enhancements:

  • Document the yarn lint:overrides command alongside the project’s other development commands, including its purpose and runtime behavior.

Documentation:

  • Update CLAUDE.md to describe how yarn lint:overrides validates ESLint per-file exemptions.

Summary by CodeRabbit

  • Documentation
    • Added guidance for the yarn lint:overrides command.
    • Documented how per-file lint exemptions are rechecked and noted the additional linting time.

PR #67 で意図的に後回しにしていた 1 行。#65 が同じブロックを編集していたので、
予測できるコンフリクトを避けるため #65 のマージ後に回していた(#67 の本文と
ledger の row 0c に記録済み)。両方マージ済みなので入れる。

所要時間を「~40s」と書きかけて実測したら 11 秒だった。41 秒は #67 のブランチでの
値で、そこでは免除が 19 個あった —— #68 が strict-boolean-expressions を解消し
max-lines 系 4 つを天井付き error にしたので、今は 14 個。config 次第で動く数を
書くのはこの検査が見つけて回っていた腐り方そのものなので、数ではなく「免除 1 つに
つき lint 1 回」という形で書いた。

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GTPpB2eHQ9eovAs6QRNsTH

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @isamu, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 3 days and 2 hours by commenting @sourcery-ai review. Upgrade to get a review now.

@sourcery-ai

sourcery-ai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds yarn lint:overrides to CLAUDE.md and explains its purpose: validating that each per-file ESLint exemption still suppresses a real issue by running lint with that rule removed, while keeping the documentation resilient to future config changes.

File-Level Changes

Change Details Files
Documents the lint override verification command alongside the existing development commands.
  • Adds yarn lint:overrides to the Commands block.
  • Explains that the command re-lints once per ESLint per-file exemption with the exempted rule removed.
  • Documents the cost as one lint run per exemption without hard-coding a configuration-dependent count.
CLAUDE.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e1c216b2-46df-4322-bd60-f2f34ba62018

📥 Commits

Reviewing files that changed from the base of the PR and between fa015dd and 2eb8b0c.

📒 Files selected for processing (1)
  • CLAUDE.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The command documentation now includes yarn lint:overrides. It explains that the command re-lints once for each per-file exemption in eslint.config.js, with the exempted rule removed.

Changes

Lint documentation

Layer / File(s) Summary
Document lint override behavior
CLAUDE.md
Adds the yarn lint:overrides command and documents its per-exemption lint behavior and cost.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 2eb8b

This documentation-only change adds the existing yarn lint:overrides command to the development command reference and introduces no actionable merge-blocking risk.

Suggested reviewers: snakajima

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: documenting yarn lint:overrides in the Commands block.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/lint-overrides-command

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@isamu
isamu merged commit 5aa2609 into main Aug 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant