Skip to content

fix: byline のぶんラチェットを上げる(main が赤い) - #72

Merged
isamu merged 1 commit into
mainfrom
fix/ratchet-after-byline
Aug 27, 2026
Merged

fix: byline のぶんラチェットを上げる(main が赤い)#72
isamu merged 1 commit into
mainfrom
fix/ratchet-after-byline

Conversation

@snakajima

@snakajima snakajima commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

main が lint で赤いので、その修正です。

#66 のマージで 2 つのファイルが、その直前に打たれた杭を越えました:

ファイル 実測
src/publishChecks.ts 1301 1303
test/test_publishChecks.ts 1500 1533

byline が「記事の描画欄を列挙している 2 つのリスト」に加わり、自分の refusal を連れてきたぶんです。

上げるのが正しい対応です

そこのコメント自身がこう書いています:

Splitting any of these is a real change rather than a move: publishChecks.ts's refusals come in families, its suite keeps each assertion beside the family it belongs to … The ratchet says so without pretending the split is imminent.

杭は成長を禁じるものではなく、成長を誰かが承認する diff の 1 行にするものです。だから伸ばしたのと同じ変更で数字を上げ、何が伸ばしたのかをコメントに書きました。分割はここでは筋が悪い、というのは #67 が既に判断済みです。

なぜ PR では赤くならなかったか

#67 がファイルの実測値で杭を打ったとき、#66 はその手前のベース(4722a99)に対して既に緑でした。二つの変更が一度も出会っていないだけで、どちらもおかしくありません —— 機能の隣にラチェットが着地したときの普通の形です。これもコメントに残しました。

確認

lint 0 error / 9 warningslint:overrides は 14 個の抑制がすべて何かを抑えている状態のまま、typecheck 0、533 pass / 0 fail、check:apps は実在 10 アプリとも PASS。

Summary by Sourcery

Raise the publish-check line-count ratchets to accommodate the article byline additions and keep main lint green.

Bug Fixes:

  • Update the publish-check file length thresholds so lint passes after adding article byline handling.

Enhancements:

  • Document why the ratchet thresholds were raised alongside the feature and why the related files remain unsplit.

`main` が lint で赤い。#66 のマージで 2 つのファイルが、その直前に打たれた
杭を越えた: `src/publishChecks.ts` 1301 → 1303、
`test/test_publishChecks.ts` 1500 → 1533。

**これはラチェットが設計どおりに働いた形なので、上げるのが正しい対応。**
そこのコメント自身が「分割は移動ではなく本当の変更で、publishChecks の
refusal は家族ごとに並んでいて、テストは各 assertion をその家族の隣に置いて
いる」と書いている。杭は成長を禁じるものではなく、**成長を誰かが承認する
diff の 1 行にする**もの。だから伸ばしたのと同じ変更で数字を上げ、何が
伸ばしたのかを書いた。

**PR では赤くならなかった理由も書いた。** #67 がファイルの実測値で杭を打った
とき、#66 はその手前のベースに対して既に緑だった。どちらもおかしくない ——
機能の隣にラチェットが着地したときの普通の形。
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b51e3ec3-e2bc-405a-bdf0-23dc5581cf1a


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR fixes main's lint failure by intentionally raising the two max-lines thresholds to the measured sizes introduced by article.byline support, with comments documenting the ratchet workflow, the merge-order interaction, and why splitting the files is not the intended fix.

File-Level Changes

Change Details Files
Raises the max-lines ratchets for the two files expanded by adding article byline handling, while documenting why the increase is intentional and why main became red only after the changes landed together.
  • Updates the thresholds from 1301 to 1303 and from 1500 to 1533.
  • Explains the byline-driven growth and the interaction between the feature change and the later ratchet pin.
  • Retains the existing rationale against splitting the related implementation and tests.
eslint.config.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@isamu
isamu merged commit 60ac1df into main Aug 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants