Skip to content

style(help-popup): glass treatment + sync pane menu shortcuts#142

Merged
NagyVikt merged 1 commit into
mainfrom
agent/claude/help-popup-design-polish-2026-05-16-01-12
May 15, 2026
Merged

style(help-popup): glass treatment + sync pane menu shortcuts#142
NagyVikt merged 1 commit into
mainfrom
agent/claude/help-popup-design-polish-2026-05-16-01-12

Conversation

@NagyVikt
Copy link
Copy Markdown
Contributor

Automated by gx branch finish (PR flow).

Refit scripts/codex-fleet/bin/help-popup.sh onto the same fg-only iOS
glass chrome as pane-context-menu.sh so the help popup matches its
sibling surface visually:

- Replace `_ios_sgr` (which emits both fg AND bg) with a local
  `menu_fg` helper that emits truecolor foreground only. Background
  stays at the terminal default so tmux popup `-B` lets the underlying
  pane show through.
- Use the agreed iOS palette: hairlines / corners #3A3A3C, section
  headers #007AFF bold (blue), key chips #FFCC00 bold (yellow), labels
  #FFFFFF, gray dot separator #8E8E93 between key + label, bottom hint
  #8E8E93.
- Sync the listed pane-menu shortcuts to current state: add `p` Paste
  from clipboard (PR #140), reword to match pane-context-menu.sh
  labels ("Copy whole session", "Swap with marked pane", …).
- Add a new "Nav (inside the pane menu)" section describing the
  arrow-nav focus model being added in the sister lane: ↑/↓ moves
  focus, ⏎ selects, esc cancels.
- Header now renders as `⌨  codex-fleet · keyboard help [ HELP ]` to
  mirror the pane menu's `● pane <idx> · <pane_id> [ LIVE ]` shape.
- Bottom hint updated to `any key closes  ·  esc/q exits`.
- Fix latent bug: top-level `local_pad=...` (outside any function)
  removed by moving header rendering into `draw_header()`.
- Smoke-test stanza added in the header comment:
  `bash scripts/codex-fleet/bin/help-popup.sh < /dev/null`.

Verification:
- bash -n scripts/codex-fleet/bin/help-popup.sh -> 0
- docker koalaman/shellcheck:stable -> 0
- grep -nE 'Paste from clipboard|↑ / ↓|⏎' -> 6 matches
- Smoke: bash help-popup.sh < /dev/null -> 0 (no solid-bg SGR in
  output: `grep -c '\[48;2;' = 0`).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@NagyVikt NagyVikt merged commit dae9057 into main May 15, 2026
@NagyVikt NagyVikt deleted the agent/claude/help-popup-design-polish-2026-05-16-01-12 branch May 15, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant