Skip to content

fix(fleet-waves): drop dead WavePreview / unfinished_waves#161

Merged
NagyVikt merged 1 commit into
mainfrom
fix/fleet-waves-dead-code
May 16, 2026
Merged

fix(fleet-waves): drop dead WavePreview / unfinished_waves#161
NagyVikt merged 1 commit into
mainfrom
fix/fleet-waves-dead-code

Conversation

@NagyVikt
Copy link
Copy Markdown
Contributor

Summary

Drops three rustc dead_code warnings that surfaced on every cargo build -p fleet-waves:

  • struct WavePreview — never constructed in production code
  • fn unfinished_waves — never called in production code; only reachable through the test below
  • fn demo_plan (test helper) — orphaned once that test was removed

Also removes the matching test unfinished_waves_skip_completed_rows. Both the function and the test were exercised together but never wired into any rendering path — the live waves view uses wave_status / first_task_title directly, not WavePreview.

Test plan

  • `cargo build --release -p fleet-waves` — clean, zero warnings (was 3)
  • `cargo test --release -p fleet-waves` — 5/5 pass (lost the 1 test that depended on the dead helpers)

Net diff

`rust/fleet-waves/src/main.rs` -98 lines.

Both were only reachable through unfinished_waves_skip_completed_rows
(also removed) and have no production callers. The supporting
demo_plan() helper was likewise orphaned and removed.

Drops three rustc dead_code warnings; cargo test still 5/5 pass.
@NagyVikt NagyVikt merged commit c2c0427 into main May 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant