fix(fleet-waves): drop dead WavePreview / unfinished_waves#161
Merged
Conversation
Both were only reachable through unfinished_waves_skip_completed_rows (also removed) and have no production callers. The supporting demo_plan() helper was likewise orphaned and removed. Drops three rustc dead_code warnings; cargo test still 5/5 pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops three rustc dead_code warnings that surfaced on every
cargo build -p fleet-waves:struct WavePreview— never constructed in production codefn unfinished_waves— never called in production code; only reachable through the test belowfn demo_plan(test helper) — orphaned once that test was removedAlso removes the matching test
unfinished_waves_skip_completed_rows. Both the function and the test were exercised together but never wired into any rendering path — the live waves view useswave_status/first_task_titledirectly, notWavePreview.Test plan
Net diff
`rust/fleet-waves/src/main.rs` -98 lines.