chore(rust): delete fleet-tui-poc throwaway crate#165
Merged
Conversation
The fleet-tui-poc crate's README declared it throwaway: "Once fleet-ui lands in rust/fleet-ui/, delete this directory." fleet-ui has since shipped the canonical overlay widgets: - `fleet-ui::overlay` — base overlay framework - `fleet-ui::spotlight_overlay` — search-first palette (was POC key `2`) - `fleet-ui::session_switcher_overlay` — card-stack switcher (was POC key `4`) The POC carried ~3470 lines of duplicate SpotlightItem / context-menu / action-sheet / session-switcher code drifting from those canonical implementations. Deleting it removes the duplication, slims the workspace Cargo.lock (fleet-tui-poc entry gone), and avoids a ratatui-version split risk should the POC and fleet-ui ever diverge. Workspace `members = ["fleet-input", "fleet-layout", "fleet-*"]` glob picks crates up by directory presence, so removing the directory is enough — no manifest edit needed. Three live shell scripts referenced the binary; updated: - bin/pane-context-menu-chooser.sh — dropped Rust branch; bash menu is now the sole renderer (always was the fallback). - bin/section-jump-chooser.sh — converted to a tmux-display stub. The overlay had no bash fallback; a fleet-ui-backed replacement is a follow-up. - full-bringup.sh — dropped the dead design-preview window block that was gated on the binary's presence. Verification: - cargo check --workspace: clean - cargo test --workspace --exclude fleet-ui: all green (217 tests) - cargo test -p fleet-ui --lib: 39/39 pass - Pre-existing broken `tab_strip_snapshot.rs` integration test (imports nonexistent `fleet_ui::tab_strip`) was failing on HEAD before this PR; unrelated to this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes the
fleet-tui-poccrate per its own README directive: "Oncefleet-uilands inrust/fleet-ui/, delete this directory."fleet-uihas shipped the canonical overlay widgets and the POC has been carrying ~3,470 lines of duplicate code that drifts from those implementations.main.rs+ 595 LOC standaloneCargo.lock+ 115 LOC README + 15 LOC Cargo.tomlfleet-tui-pocentry dropped from the workspace lockCanonical replacements (already in
fleet-ui)fleet-uias1Context menufleet-ui::overlay(base overlay framework)2Spotlight palettefleet-ui::spotlight_overlay4Session switcherfleet-ui::session_switcher_overlayWorkspace glob behavior
rust/Cargo.tomlusesmembers = ["fleet-input", "fleet-layout", "fleet-*"]— the glob picks crates up by directory presence, so removingrust/fleet-tui-poc/drops it automatically; no manifest edit needed.Ratatui version concern (operator review item #9 quick wins)
Inspected workspace
Cargo.lockbefore/after delete: onlyratatui = "0.30.0"was/is present. The POC was already aligned at 0.30, so deleting it does not change the ratatui-version count in the workspace lock. The risk the quick-win flagged (POC pinning a different ratatui from production crates) is now eliminated by construction — the POC is simply gone.Live script call sites updated
Three shell scripts invoked the POC binary at runtime:
scripts/codex-fleet/bin/pane-context-menu-chooser.sh— dropped the Rust branch (it already had a bash fallback; the bash menu is now the sole renderer).scripts/codex-fleet/bin/section-jump-chooser.sh— converted to atmux display-messagestub. The section-jump overlay had no bash fallback; afleet-ui-backed port is a follow-up. Theprefix Tabkeybinding (fromtmux-bindings.conf) now shows a "pending" toast instead of a "not built" toast.scripts/codex-fleet/full-bringup.sh— removed the deadif [ -x .../fleet-tui-poc ]block that opened an optional design-preview tmux window.Historical README / changelog / openspec prose was left alone per task spec.
Test plan
cargo check --workspace— clean compilecargo test --workspace --exclude fleet-ui— all 217 tests passcargo test -p fleet-ui --lib— 39/39 passgrep -rn fleet_tui_poc rust/returns 0 hitsgrep -rn fleet-tui-poc rust/*/Cargo.tomlreturns 0 hits (no inbound dep)prefix Tabtoast change is acceptable until afleet-uisection-jump port landsPre-existing test note
rust/fleet-ui/tests/tab_strip_snapshot.rsimportsfleet_ui::tab_strip::{...}which doesn't exist infleet-ui/src/lib.rs. This test was already failing to compile onHEADbefore this PR (last touched in #117 "Add fleet-ui spotlight overlay widget"). Unrelated to this change — leaving it for whoever owns the tab_strip module migration.Follow-ups (out of scope here)
fleet-uiand re-wiresection-jump-chooser.sh.fleet-design-previewbinary if operators want the multi-overlay preview window back.tab_strip_snapshot.rstest (separate cleanup).