Repository navigation
Read class-like short names through ClassNameImportContext in ClassLikeName skip voter - #8695
Merged
Merged
Conversation
…keName skip voter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ClassLikeNameClassNameImportSkipVoterdepended onShortNameResolverdirectly. It now reads the declared class-like short names through the sharedClassNameImportContext, continuing the consolidation from #8687 and #8691.Change
ClassNameImportContextgainsresolveShortClassLikeNames(File), delegating toShortNameResolver::resolveShortClassLikeNames()(already version-cached).ShortNameResolver; its namespace/scope comparison andNamespaceBeforeClassNameResolverusage are unchanged.Pure consolidation - no behavior change, performance unchanged. Three of the five file-scanning voters now read from one place.
Tests
148 import tests green (
rules-tests/CodingStyle/ClassNameImport,ImportFullyQualifiedNamesRector,tests/Issues/AutoImport*,NamespacedUseAutoImport, docblock import). ECS + full PHPStan clean.