Repository navigation
[TypeDeclaration] Deprecate BinaryOpNullableToInstanceofRector, fold into ExplicitNullableObjectInstanceRector - #8817
Merged
Conversation
…into ExplicitNullableObjectInstanceRector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folds
BinaryOpNullableToInstanceofRectorintoExplicitNullableObjectInstanceRector, continuing the campaign that already mergedFlipTypeControlToUseExclusiveTypeRector,ObjectExplicitBoolCompareRector,EmptyOnNullableObjectToInstanceOfRectorandWhileNullableToInstanceofRectorinto one rule.ExplicitNullableObjectInstanceRectornow also subscribes toBooleanAnd/BooleanOrand turns nullable-object truthiness operands into explicitinstanceofchecks (including the!$a || !$bnegation shape). The old rule is deprecated (throws viaDeprecatedInterface) and removed fromTypeDeclarationLevel.Its fixtures and source classes moved under the
ExplicitNullableObjectInstanceRectortest with abinaryop_prefix; all 28 tests pass.