Repository navigation
[Testing] Lock the fixture directory while a test uses its temp file - #8822
Merged
TomasVotruba merged 1 commit intoOct 25, 2026
Merged
Conversation
Member
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PolyfillRectorTestandStrStartsWithRectorTestuse the sameFixture/directory. When fast-unit runs them at the same time, one test can delete the other's temp file, as in #8517. This failedmainthree times this month, for example https://github.com/rectorphp/rector-src/actions/runs/37998247855.doTestFile()now locks.fixture.lockin the fixture directory untiltearDown(). Only tests that share a directory wait for each other.Two processes started together failed 7 of 10 times before this change, and 0 of 10 after.