Skip to content

Return node when node mutated in place, so change is recorded #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Oct 24, 2026
Merged

Return node when node mutated in place, so change is recorded #1087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions rules/Symfony30/Rector/MethodCall/FormTypeInstanceToClassConstRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,20 +107,29 @@ public function refactor(Node $node): ?Node
}

// special case for collections
$hasChangedCollection = false;
if ($this->formCollectionAnalyzer->isCollectionType($node)) {
$this->refactorCollectionOptions($node);
$hasChangedCollection = $this->refactorCollectionOptions($node);
}

return $this->formInstanceToFormClassConstFetchConverter->processNewInstance($node, 1, 2);
$newMethodCall = $this->formInstanceToFormClassConstFetchConverter->processNewInstance($node, 1, 2);
if ($newMethodCall instanceof MethodCall) {
return $newMethodCall;
}

// collection options were mutated in place, report the change via the return value
return $hasChangedCollection ? $node : null;
}

private function refactorCollectionOptions(MethodCall $methodCall): void
private function refactorCollectionOptions(MethodCall $methodCall): bool
{
$optionsArray = $this->formOptionsArrayMatcher->match($methodCall);
if (! $optionsArray instanceof Array_) {
return;
return false;
}

$hasChanged = false;

foreach ($optionsArray->items as $arrayItem) {
if (! $arrayItem instanceof ArrayItem) {
continue;
Expand All @@ -145,6 +154,9 @@ private function refactorCollectionOptions(MethodCall $methodCall): void
}

$arrayItem->value = $this->nodeFactory->createClassConstReference($newClass->toString());
$hasChanged = true;
}

return $hasChanged;
}
}
Loading