chore: remove duplicated sequential E2E tests

[jgwest]

What does this PR do?

Courtesy of claude:

1. 1-002-validate_backend_service_test.go + 1-026-validate_backend_service_permissions_test.go — both had an identical It("validates backend service permissions", ...) checking the same cluster Deployment/Service in openshift-gitops. Merged into 1-002, folding in 026's ServiceAccount/ClusterRole/ClusterRoleBinding assertions. Deleted 1-026.

2. 1-105_validate_default_argocd_route_test.go + 1-111_validate_default_argocd_route_test.go — functionally identical: both verify the default openshift-gitops-server Route/TLS secret and both mutate .spec.server.route.tls to Passthrough/None and re-verify. Kept 1-105 (uses the richer routeFixture matchers), deleted 1-111.

3. 1-074_validate_terminating_namespace_block_test.go + 1-102_validate_handle_terminating_namespaces_test.go — same scenario (a managed namespace stuck terminating due to a finalizer must not block reconciliation of other managed namespaces). 1-102 is a strict superset — it does everything 1-074 does (verify RoleBindings appear in the second namespace) plus an actual Application deploy/sync check. Deleted 1-074, kept 1-102.

I've humanly verified that we're not losing test coverage with the result.

PR acceptance criteria:

• Documentation was updated and verified using make serve-docs
• Unit tests were updated
• E2E tests were updated

What type of PR is this?

/kind cleanup

Special notes to the reviewer:

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository YAML (base), Organization UI (inherited)
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 8c17bb17-6cf8-4c03-b6e8-690f36d30ed0

📥 Commits

Reviewing files that changed from the base of the PR and between d57effa and abd415a.

📒 Files selected for processing: 2

• test/openshift/e2e/ginkgo/parallel/1-002-validate_backend_service_test.go
• test/openshift/e2e/ginkgo/parallel/1-026-validate_backend_service_permissions_test.go

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• argoproj-labs/argocd-operator (manual)

💤 Files with no reviewable changes: 1

• test/openshift/e2e/ginkgo/parallel/1-026-validate_backend_service_permissions_test.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

• Tests
  • Added end-to-end checks that the cluster deployment uses the expected service account and that its account, cluster role, and role binding are configured correctly.
  • Removed the separate backend permissions test, along with end-to-end tests for namespace reconciliation and the default OpenShift route, including route TLS settings and certificate checks.

The E2E tests now check the backend service Deployment’s service account and related RBAC resources. The changes also remove sequential tests for terminating namespace reconciliation and default Argo CD route settings.

Changes: Backend service RBAC validation

Layer / File(s)	Summary
Backend service account and RBAC checks test/openshift/e2e/ginkgo/parallel/1-002-validate_backend_service_test.go, test/openshift/e2e/ginkgo/parallel/1-026-validate_backend_service_permissions_test.go	The backend service test checks the Deployment’s service account, the gitops-service-cluster ServiceAccount, its ClusterRole rules, and its ClusterRoleBinding. The separate permissions test was removed.

Namespace reconciliation test removal

Layer / File(s)	Summary
Terminating namespace test test/openshift/e2e/ginkgo/sequential/1-074_validate_terminating_namespace_block_test.go	The sequential test for RoleBinding creation in a second managed namespace while another managed namespace is terminating was removed.

Default Argo CD route test removal

Layer / File(s)	Summary
Default route settings test test/openshift/e2e/ginkgo/sequential/1-111_validate_default_argocd_route_test.go	The test for default route settings, TLS secret type, route configuration updates, and cleanup was removed.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Suggested reviewers: anandrkskd

Merge Risk: ⚪ Minimal · up to abd41

The retained E2E tests cover the removed scenarios, so this change is ready for normal merge checks.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly and concisely identifies the main change: removing duplicated sequential E2E tests.
Description check		The description directly explains which E2E tests were consolidated or removed and states the intended coverage outcome.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chetan-rns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment