Skip to content

Lightspeed Core Service 0.5.2#459

Merged
openshift-merge-bot[bot] merged 3 commits into
redhat-developer:release-1.10from
michael-valdron:lcs-0.5.2
Jul 1, 2026
Merged

Lightspeed Core Service 0.5.2#459
openshift-merge-bot[bot] merged 3 commits into
redhat-developer:release-1.10from
michael-valdron:lcs-0.5.2

Conversation

@michael-valdron

@michael-valdron michael-valdron commented Jun 30, 2026

Copy link
Copy Markdown
Member

Description of the change

Patches Lightspeed Core Service (or Lightspeed Stack) to use v0.5.2.

Which issue(s) does this PR fix or relate to

How to test changes / Special notes to the reviewer

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Run pre-commit run --all-files to run the hooks and then push any resulting changes. The pre-commit Workflow will enforce this and warn you if needed.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron michael-valdron marked this pull request as ready for review June 30, 2026 19:39
@michael-valdron michael-valdron requested a review from a team as a code owner June 30, 2026 19:39
@rhdh-qodo-merge

Copy link
Copy Markdown

PR Summary by Qodo

Bump Backstage Helm chart to Lightspeed Core Service 0.5.2

⚙️ Configuration changes 📝 Documentation 🕐 10-20 Minutes

Grey Divider

AI Description

• Bump Backstage Helm chart version to 5.12.5.
• Update default Lightspeed Core sidecar image to lightspeed-stack:0.5.2.
• Regenerate/align schema and documentation with the new default image tag.
Diagram

graph TD
  A["Backstage Helm chart"] --> B["Chart version 5.12.5"] --> C["Default values"] --> D["Helm render"] --> E["Backstage Pod"] --> F["Lightspeed sidecar"] --> G{{"quay.io lightspeed-stack:0.5.2"}}
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Centralize LCS version as a single chart value
  • ➕ Avoids updating the same version in multiple places (values + schema + docs)
  • ➕ Makes future bumps less error-prone (one source of truth)
  • ➖ Requires small refactor of schema/docs generation and possibly templates
  • ➖ May be less explicit than a full image reference when supporting disconnected overrides
2. Use chart appVersion to track Lightspeed version (and reference it in docs)
  • ➕ Clear separation: chart version vs bundled component version
  • ➕ Common Helm convention for component versioning
  • ➖ Still requires ensuring the actual image tag matches appVersion
  • ➖ Doesn’t remove the need to set the full image ref for disconnected environments

Recommendation: Current approach is acceptable for a patch bump: it consistently updates Chart.yaml, README, values.yaml, and values.schema.json. If these bumps happen frequently, consider centralizing the Lightspeed version (or aligning via appVersion) to reduce multi-file drift and simplify future releases.

Files changed (4) +6 / -6

Documentation (1) +3 / -3
README.mdAlign docs with chart 5.12.5 and Lightspeed 0.5.2 +3/-3

Align docs with chart 5.12.5 and Lightspeed 0.5.2

• Updates the version badge and installation example to 5.12.5. Also updates the documented default Lightspeed sidecar image tag to 0.5.2.

charts/backstage/README.md

Other (3) +3 / -3
Chart.yamlBump chart version to 5.12.5 +1/-1

Bump chart version to 5.12.5

• Updates the Helm chart version from 5.12.4 to 5.12.5 to publish a new chart release containing the Lightspeed 0.5.2 default.

charts/backstage/Chart.yaml

values.schema.jsonRegenerate schema default Lightspeed image to 0.5.2 +1/-1

Regenerate schema default Lightspeed image to 0.5.2

• Updates the JSON schema default for the Lightspeed sidecar image from 0.5.1 to 0.5.2 to match chart defaults.

charts/backstage/values.schema.json

values.yamlUpdate default Lightspeed sidecar image tag to 0.5.2 +1/-1

Update default Lightspeed sidecar image tag to 0.5.2

• Bumps the default 'global.lightspeed.sidecar.image' from 'lightspeed-stack:0.5.1' to 'lightspeed-stack:0.5.2'.

charts/backstage/values.yaml

@rhdh-qodo-merge

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@rhdh-qodo-merge rhdh-qodo-merge Bot added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 30, 2026
Comment thread charts/backstage/values.yaml
@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2026

Copy link
Copy Markdown

@openshift-ci openshift-ci Bot added the lgtm label Jul 1, 2026
@rm3l

rm3l commented Jul 1, 2026

Copy link
Copy Markdown
Member

/cherry-pick main

@openshift-cherrypick-robot

Copy link
Copy Markdown

@rm3l: once the present PR merges, I will cherry-pick it on top of main in a new PR and assign it to you.

Details

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit 6e6b526 into redhat-developer:release-1.10 Jul 1, 2026
6 checks passed
@openshift-cherrypick-robot

Copy link
Copy Markdown

@rm3l: #459 failed to apply on top of branch "main":

Applying: lcs 0.5.2
Using index info to reconstruct a base tree...
M	charts/backstage/Chart.yaml
M	charts/backstage/README.md
M	charts/backstage/values.schema.json
M	charts/backstage/values.yaml
Falling back to patching base and 3-way merge...
Auto-merging charts/backstage/Chart.yaml
CONFLICT (content): Merge conflict in charts/backstage/Chart.yaml
Auto-merging charts/backstage/README.md
CONFLICT (content): Merge conflict in charts/backstage/README.md
Auto-merging charts/backstage/values.schema.json
Auto-merging charts/backstage/values.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 lcs 0.5.2

Details

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rm3l added a commit that referenced this pull request Jul 1, 2026
Co-authored-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants