fix: resolve wrapper plugins to metadata path in nightly mode#94
Merged
jrichter1 merged 1 commit intoredhat-developer:mainfrom May 4, 2026
Merged
Conversation
When metadata has a wrapper path (./dynamic-plugins/dist/...) but user config has a stale OCI ref, nightly mode now correctly resolves to the wrapper path from metadata instead of passing through the stale ref. Adds reproducing test, plugin metadata resolution docs, version bump to 1.1.36, and changelog entry. Assisted-by: Claude Code <noreply@anthropic.com>
jrichter1
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA : https://redhat.atlassian.net/browse/RHDHBUGS-3058
Summary
Root Cause
resolvePluginPackages()only replaced the package field when metadata had an OCI path. When metadata had a wrapper path (./dynamic-plugins/dist/...), the code fell through toreturn pluginunchanged — keeping stale OCI refs from user config.Fix
Always use
metadata.packagePathas the source of truth, regardless of whether it's OCI or wrapper.Test plan
plugin-metadata.nightly.test.ts)yarn checkpasses (typecheck + lint + prettier)Assisted-by: Claude Code noreply@anthropic.com