Skip to content

fix: resolve wrapper plugins to metadata path in nightly mode#94

Merged
jrichter1 merged 1 commit intoredhat-developer:mainfrom
subhashkhileri:nightly-wrapper-replacemnet-issue
May 4, 2026
Merged

fix: resolve wrapper plugins to metadata path in nightly mode#94
jrichter1 merged 1 commit intoredhat-developer:mainfrom
subhashkhileri:nightly-wrapper-replacemnet-issue

Conversation

@subhashkhileri
Copy link
Copy Markdown
Member

@subhashkhileri subhashkhileri commented Apr 30, 2026

JIRA : https://redhat.atlassian.net/browse/RHDHBUGS-3058

Summary

  • Fixes nightly mode passing through stale OCI refs when metadata specifies a wrapper path
  • Adds reproducing unit test for the exact failure scenario (github-org plugin)
  • Adds comprehensive Plugin Metadata Resolution documentation under overlay/reference
  • Bumps version to 1.1.36

Root Cause

resolvePluginPackages() only replaced the package field when metadata had an OCI path. When metadata had a wrapper path (./dynamic-plugins/dist/...), the code fell through to
return plugin unchanged — keeping stale OCI refs from user config.

Fix

Always use metadata.packagePath as the source of truth, regardless of whether it's OCI or wrapper.

Test plan

  • Reproducing test added (plugin-metadata.nightly.test.ts)
  • All 43 tests pass across 14 suites
  • yarn check passes (typecheck + lint + prettier)

Assisted-by: Claude Code noreply@anthropic.com

When metadata has a wrapper path (./dynamic-plugins/dist/...) but user
config has a stale OCI ref, nightly mode now correctly resolves to the
wrapper path from metadata instead of passing through the stale ref.

Adds reproducing test, plugin metadata resolution docs, version bump
to 1.1.36, and changelog entry.

Assisted-by: Claude Code <noreply@anthropic.com>
@jrichter1 jrichter1 merged commit a23767c into redhat-developer:main May 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants