Skip to content

Fix extension loading #3005#3006

Closed
gayanper wants to merge 1 commit intoredhat-developer:masterfrom
gayanper:fix_loading
Closed

Fix extension loading #3005#3006
gayanper wants to merge 1 commit intoredhat-developer:masterfrom
gayanper:fix_loading

Conversation

@gayanper
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Gayan Perera <gayanper@gmail.com>
@gayanper
Copy link
Copy Markdown
Contributor Author

Please let me know if there is a better way to fix the issue, I'm not a JS/TS expert, so the fix is a more naive fix.

@gayanper
Copy link
Copy Markdown
Contributor Author

@rgrunber @jdneo Let me know if there is another way to solve this

@snjeza
Copy link
Copy Markdown
Collaborator

snjeza commented Mar 18, 2023

The issue happens when setting java.jdt.ls.java.home.
The PR fixes it.

@snjeza snjeza self-requested a review March 18, 2023 19:33
@fbricon
Copy link
Copy Markdown
Collaborator

fbricon commented Mar 18, 2023

can anyone explain why this patch fixes the issue? It seems wrong, but I suck at JS/TS

@gayanper
Copy link
Copy Markdown
Contributor Author

I'm not an expert either, but i guess it could be something to do with how import and require load the JS module.

I doubt if it could be due to a recent electron + NodeJS runtime change.

@CsCherrYY
Copy link
Copy Markdown
Contributor

can anyone explain why this patch fixes the issue? It seems wrong, but I suck at JS/TS

This issue should be related to the config change of #2967, this PR introduces some project configurations related to webview (react) might be incompatible with existing statements.

I created a new PR for this #3009 , which might resolve this issue and avoid any potential issue in the future

@jdneo
Copy link
Copy Markdown
Collaborator

jdneo commented Mar 20, 2023

To add more information: https://www.typescriptlang.org/tsconfig#esModuleInterop

@jdneo
Copy link
Copy Markdown
Collaborator

jdneo commented Mar 20, 2023

With #3009, we can close this PR.

@gayanper gayanper closed this Mar 21, 2023
@gayanper gayanper deleted the fix_loading branch March 21, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants