Fix extension loading #3005#3006
Conversation
Signed-off-by: Gayan Perera <gayanper@gmail.com>
|
Please let me know if there is a better way to fix the issue, I'm not a JS/TS expert, so the fix is a more naive fix. |
|
The issue happens when setting |
|
can anyone explain why this patch fixes the issue? It seems wrong, but I suck at JS/TS |
|
I'm not an expert either, but i guess it could be something to do with how import and require load the JS module. I doubt if it could be due to a recent electron + NodeJS runtime change. |
This issue should be related to the config change of #2967, this PR introduces some project configurations related to webview (react) might be incompatible with existing statements. I created a new PR for this #3009 , which might resolve this issue and avoid any potential issue in the future |
|
To add more information: https://www.typescriptlang.org/tsconfig#esModuleInterop |
|
With #3009, we can close this PR. |
No description provided.