Install update#56
Open
dvalinrh wants to merge 6 commits into
Open
Conversation
Review Summary by QodoUpdate HammerDB installation and add comprehensive TPCC benchmark support for multiple databases
WalkthroughsDescription• Refactored HammerDB installation process to download from GitHub releases instead of requiring local kit uploads • Fixed MSSQL installation to use RHEL 9 packages with dnf instead of yum • Updated all hardcoded /usr/local/HammerDB paths to use configurable $hmd_dir variable for flexible deployment • Removed upload parameter (-u) from installation scripts, simplifying the deployment workflow • Added comprehensive TPCC benchmark scripts for MariaDB, PostgreSQL, MSSQL, and Oracle databases • Implemented database build scripts with automatic configuration (buffer pools, tempdb optimization, traceflags) • Added multi-host and multi-VM benchmark execution scripts for distributed testing across multiple database instances • Created performance tuning configuration files for all supported databases (my.cnf, postgresql.conf, mssql.conf) • Added extensive documentation for TPCC setup on RHEL 7/8, OpenShift, Podman containers, and persistent memory configurations • Implemented statistics collection during benchmark runs (vmstat, iostat, system metrics) • Added Oracle database support with initialization parameters, listener configuration, and startup/shutdown scripts • Enhanced wrapper scripts to support local directory installations instead of system-wide paths Diagramflowchart LR
A["Installation Script"] -->|Download from GitHub| B["HammerDB Binary"]
A -->|Configure| C["MSSQL/MariaDB/PostgreSQL/Oracle"]
B -->|Build Schema| D["TPCC Database"]
D -->|Execute| E["Benchmark Tests"]
E -->|Collect| F["Performance Metrics"]
F -->|Generate| G["CSV Results"]
H["Multi-Host Scripts"] -->|Distribute| I["Multiple DB Instances"]
I -->|Parallel Execution| E
File Changes1. hammerdb/hammerdb_scripts/mssql/podman/update_temp.sh
|
Code Review by Qodo
1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Contributor
Author
|
Qodo: Unverified root installer download, this has always been there, not worried about it. vim file removed. |
frival
reviewed
May 26, 2026
frival
reviewed
May 26, 2026
frival
reviewed
May 26, 2026
frival
reviewed
May 26, 2026
frival
reviewed
May 26, 2026
frival
reviewed
May 26, 2026
frival
reviewed
May 26, 2026
There was a problem hiding this comment.
We should double-check with Sanjay that this is still the valid my.cnf he's using. We'll also have to think about how to manage upstream updates (particularly breaking or contrary default changes).
frival
reviewed
May 26, 2026
frival
reviewed
May 26, 2026
frival
reviewed
May 26, 2026
frival
reviewed
May 26, 2026
frival
reviewed
May 28, 2026
frival
reviewed
May 28, 2026
frival
reviewed
May 28, 2026
frival
reviewed
May 28, 2026
frival
reviewed
May 28, 2026
frival
reviewed
May 28, 2026
| dbset db mssqls | ||
| dbset bm TPC-C | ||
| diset connection mssqls_linux_server 127.0.0.1 | ||
| diset connection mssqls_pass 100yard- |
There was a problem hiding this comment.
We should talk about this one I think...
frival
reviewed
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update hammerdb installation process, including fixing mssql
Before/After Comparison
Before: We had to upload the kit for hammerdb, and we are running the wrong version of mssql
After: The wrapper now handles loading everything it needs, and runs the proper mssql version/
Clerical Stuff
This closes #55
Relates to JIRA: RPOPC-922
Testing:
Verified mariadb, mssql, and postgres all run properly.
mariadb csv file
connection,TPM,Start_Date,End_Date
10,148610,2026-05-05T16:51:32Z,2026-05-05T17:08:40Z
20,142877,2026-05-05T17:08:50Z,2026-05-05T17:25:58Z
40,134952,2026-05-05T17:26:08Z,2026-05-05T17:43:16Z
postgres csv file
connection,TPM,Start_Date,End_Date
10,191257,2026-05-06T11:38:22Z,2026-05-06T11:55:30Z
20,186956,2026-05-06T11:55:40Z,2026-05-06T12:12:48Z
40,180997,2026-05-06T12:12:58Z,2026-05-06T12:30:06Z
mssql csv file
connection,TPM,Start_Date,End_Date
10,209219,2026-05-07T01:24:16Z,2026-05-07T01:40:24Z
20,257094,2026-05-07T01:40:34Z,2026-05-07T01:56:47Z
40,272160,2026-05-07T01:56:57Z,2026-05-07T02:13:10Z
New version has also been used in doing hammerdb runs on AWS and azure regresssions.