Skip to content

Always pass dry-run parameter #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justin-cechmanek merged 2 commits into from
Apr 6, 2026
+22 −3
Merged

Always pass dry-run parameter #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be77bc5
always pass dry-run parameter
justin-cechmanek Mar 31, 2026
545eeb2
adds unit test for dry_run parameter
justin-cechmanek Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions agent-memory-client/agent_memory_client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,8 +833,8 @@ async def forget_long_term_memories(
params["session_id"] = session_id
if limit is not None:
params["limit"] = limit
if dry_run:
params["dry_run"] = dry_run
# Always pass dry_run explicitly because the server default is True.
params["dry_run"] = dry_run

body = {"policy": policy.model_dump(exclude_none=True)}
if pinned_ids:
Expand Down
21 changes: 20 additions & 1 deletion agent-memory-client/tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,6 +1025,11 @@ async def test_forget_long_term_memories_basic(self, enhanced_test_client):
assert result.deleted == 5
assert len(result.deleted_ids) == 5
assert result.dry_run is False
enhanced_test_client._client.post.assert_called_once_with(
"/v1/long-term-memory/forget",
params={"dry_run": False},
json={"policy": {"max_age_days": 30}},
)

@pytest.mark.asyncio
async def test_forget_long_term_memories_dry_run(self, enhanced_test_client):
Expand All @@ -1048,6 +1053,11 @@ async def test_forget_long_term_memories_dry_run(self, enhanced_test_client):

assert isinstance(result, ForgetResponse)
assert result.dry_run is True
enhanced_test_client._client.post.assert_called_once_with(
"/v1/long-term-memory/forget",
params={"dry_run": True},
json={"policy": {"max_inactive_days": 14}},
)

@pytest.mark.asyncio
async def test_forget_long_term_memories_with_filters(self, enhanced_test_client):
Expand All @@ -1070,7 +1080,16 @@ async def test_forget_long_term_memories_with_filters(self, enhanced_test_client
)

assert isinstance(result, ForgetResponse)
enhanced_test_client._client.post.assert_called_once()
enhanced_test_client._client.post.assert_called_once_with(
"/v1/long-term-memory/forget",
params={
"namespace": "test-ns",
"user_id": "user-1",
"session_id": "sess-1",
"dry_run": False,
},
json={"policy": {"budget": 100}},
)


# ==================== Summary Views Tests ====================
Expand Down
Loading