Added intrastructure and integration point with OTel #3864
Conversation
| return attrs | ||
|
|
||
| @staticmethod | ||
| def build_connection_pool_attributes( |
There was a problem hiding this comment.
Having in mind that this is for the connection pool, not for a concrete connection, connection_state and is_pubsub seem strange - they are specific per connection.
| def __init__( | ||
| self, | ||
| # Core enablement | ||
| enabled_telemetry: List[TelemetryOption] = None, |
| enabled_telemetry: List[TelemetryOption] = None, | ||
| # Metrics-specific | ||
| metrics_sample_percentage: float = 100.0, | ||
| metric_groups: List[MetricGroup] = None, |
| from opentelemetry.metrics import NoOpMeterProvider | ||
| except ImportError: | ||
| raise ImportError( | ||
| "OpenTelemetry is not installed. Install it with:\n" |
There was a problem hiding this comment.
Those libs can be added in the toml file as optional dependencies
| if enabled_telemetry is None: | ||
| self.enabled_telemetry = self.DEFAULT_TELEMETRY | ||
| else: | ||
| self.enabled_telemetry = TelemetryOption(0) |
There was a problem hiding this comment.
We have to somehow use the input values. This way the user might configure a list of options and to expect that they should be working. I believe here the provided list should be checked and if invalid ot not yet supported options are provided - an error should be either logged or raised.
| import pytest | ||
| from unittest.mock import MagicMock, patch | ||
|
|
||
| from redis.observability import recorder |
There was a problem hiding this comment.
I don't see the new otel dependencies added to the dev-dependencies list - aren't they needed for the successful test execution?
Description of change
Please provide a description of the change here.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.