Repository navigation
fix(cloud): warn when a subscription's databases cannot be fetched in database list - #1322
Open
pcbeingused333 wants to merge 2 commits into
Open
pcbeingused333 wants to merge 2 commits into
pcbeingused333 wants to merge 2 commits into
Conversation
… database list cloud database list swallowed per-subscription fetch errors with .ok(), so databases silently disappeared from the output. Print a warning on stderr naming the subscription and error and keep listing the rest. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redisctl cloud database listsilently dropped every database of a subscription whose/databasesrequest failed (403, 5xx, timeout), so the output looked complete but was not.Cause
list_databasesincommands/cloud/database.rsfetched per-subscription databases with.get_raw(...).await.ok(), discarding the error for both flexible and fixed subscriptions.Fix
Warning: failed to fetch databases for subscription <id> (<name>): <error>; ...on stderr, then continue with the remaining subscriptions. stdout (JSON/table) is unchanged, and the exit code stays 0 to keep partial listings usable.Tests
Disclosure: this change was prepared with the help of an AI coding assistant (Claude Code).