Skip to content

Detect page-set changes when flagging adp-docs follow-ups #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JakeSCahill merged 1 commit into from
Aug 3, 2026
+16 −3
Merged

Detect page-set changes when flagging adp-docs follow-ups #1871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions .github/workflows/update-rpk-plugin-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,23 @@ jobs:
git diff --staged --name-only | head -20
fi

# Structural changes (commands added/removed/deprecated) matter for
# downstream consumers with static stubs (adp-docs for rpk ai)
if grep -qE '\| (New|Removed|Deprecated) commands +\|' "${{ runner.temp }}/pr-summary.md" 2>/dev/null; then
# Structural changes matter for downstream consumers with static
# stubs (adp-docs for rpk ai). Two independent signals, because the
# command tree and the page set can change independently: the rpk ai
# connection pages appeared with ZERO tree changes (the commands
# existed as stubs in 0.2.31; removing their overrides excludes is
# what created the pages), so the summary-table grep alone missed
# it. Any added, deleted, or renamed page/partial for this plugin is
# structural; pure content modifications are not.
PLUGIN="${{ steps.params.outputs.plugin }}"
PAGESET_CHANGE=$(git diff --staged --name-status -- \
"modules/reference/partials/rpk-${PLUGIN}" \
"modules/reference/pages/rpk/rpk-${PLUGIN}" \
| grep -cE '^[ADR]' || true)
if [ "$PAGESET_CHANGE" -gt 0 ] || \
grep -qE '\| (New|Removed|Deprecated) commands +\|' "${{ runner.temp }}/pr-summary.md" 2>/dev/null; then
echo "structural=true" >> $GITHUB_OUTPUT
[ "$PAGESET_CHANGE" -gt 0 ] && echo "Page-set change detected: $PAGESET_CHANGE added/deleted/renamed page(s)"
else
echo "structural=false" >> $GITHUB_OUTPUT
fi
Expand Down
Loading