gitignore: anchor redpanda-check to repo root#8
Open
vuldin wants to merge 1 commit into
Open
Conversation
The unanchored `redpanda-check` pattern was matching the cmd/redpanda-check/ directory in addition to the goreleaser-built binary at the repo root. That forced contributors to `git add -f cmd/redpanda-check/main.go` when editing the only source file in that directory. Anchor the pattern with a leading slash so it only ignores the built binary at the repo root. `cmd/redpanda-check/` is left untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignorefromredpanda-checkto/redpanda-checkso the pattern is anchored to the repo root.Why
The unanchored
redpanda-checkpattern matches any path component namedredpanda-checkat any depth — which includescmd/redpanda-check/, the directory holdingmain.go. The intent of this ignore entry is the goreleaser-built binary that lands at the repo root.Discovered while editing
cmd/redpanda-check/main.gofor PR #7:git add cmd/redpanda-check/main.goerrored withThe following paths are ignored by one of your .gitignore files: cmd/redpanda-check, requiringgit add -fto bypass.Test plan
git check-ignore -v redpanda-check→ matches/redpanda-check(the root binary is still ignored).git check-ignore -v cmd/redpanda-check→ no match (the cmd directory is no longer ignored).git check-ignore -v target/dist→ still matchesdist/(goreleaser output still ignored as intended).git check-ignore -v resources/plugin_uploader/.venv→ still matches.venv/.