[v25.3.x] datalake: validate iceberg_rest_catalog_endpoint at config time#30569
Merged
WillemKauf merged 1 commit intoMay 22, 2026
Conversation
A malformed `iceberg_rest_catalog_endpoint` (e.g. one that fails `ada::parse`) causes start-up to fail, originating from a throw in `endpoint_to_address` and propagated out of `datalake_manager::start()`/ `coordinator_manager::start()`. There is no opportunity for the user to correct the value short of editing the cluster config file by hand. Extract the URL-parse check into `datalake::parse_iceberg_rest_catalog_endpoint()`, have `endpoint_to_address` call it first, and apply the same check as a property validator on `iceberg_rest_catalog_endpoint` so bad values are rejected by `rpk cluster config set` rather than crashing the broker on the next restart. (cherry picked from commit eaaaae4)
WillemKauf
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #30535
Conflict details
implementation_depsconflicted because v25.3.x uses//src/v/thirdparty/opensslinstead of@openssl. Kept the target branch's//src/v/thirdparty/openssland added the new//src/v/datalake:validatorsdep from the cherry-picked commit.