[v26.1.x] storage: move call to transactional_stm_type() out of noexcept c-tor#30588
Merged
WillemKauf merged 2 commits intoMay 22, 2026
Merged
Conversation
…c-tor This function call, `transactional_stm_type()`, used to just check the `_tx_stm` status - however, now it performs a `check_status()` call, which will throw a `gate_closed_exception()` if the `_status` is `status::shutting_down`: f935a80. Because of this change, when this function throws (i.e. during shutdown), the previously truly `noexcept` constructor now causes an abort of the program. Move the call to outside of the `noexcept` constructor to prevent this race from terminating the program. (cherry picked from commit 58ad150)
Because why are we doing this? (cherry picked from commit 519fcf3)
WillemKauf
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #30581