Add CircleCI 2.0 with shield and CodeCov with shield. #1
Open
MichaelDimmitt wants to merge 4 commits intoreergymerej:masterfrom
Open
Add CircleCI 2.0 with shield and CodeCov with shield. #1MichaelDimmitt wants to merge 4 commits intoreergymerej:masterfrom
MichaelDimmitt wants to merge 4 commits intoreergymerej:masterfrom
Conversation
c4dbef5 to
aa53e7c
Compare
4d8f5d0 to
3301c71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
72 percent code coverage, nice!
For an example of what it looks like, see my default branch, https://github.com/MichaelDimmitt/react-testing-talk
I will be adding to the documentation for this pull request after it has been merged or closed. To improve readability of the process for setting code coverage up on a create react app.
link1: code coverage from create react app issues page
link2: code coverage from create react app docs
link3: use yarn test instead of npm test
Was a bit more of a challenge because we are using CircleCI instead of travis. But no worries got it working.
Lastly, codecov needed to be curled to get the report sent to their website.
CodeCov and CircleCI service is free for open source projects.