docs: enterprise component field notes (ag-grid, map, react flow)#6781
docs: enterprise component field notes (ag-grid, map, react flow)#6781amsraman wants to merge 2 commits into
Conversation
New AG Grid pages for tree data and master-detail (previously undocumented), selection/filtering/fill-handle additions, a model-wrapper kwarg bug fix (class_model -> model_class), formatter and cell-renderer patterns; Leaflet map icon dicts and map-API pitfalls; React Flow controlled-state wiring, provider constraints, and screen_to_flow_position. Sidebar entries registered for the new pages. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Merging this PR will not alter performance
Comparing Footnotes
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 196cbfd86b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| class State(rx.State): | ||
| # Dynamic variant: update these vars to reconfigure the grid | ||
| detail_cell_renderer_params: dict = STATIC_DETAIL_PARAMS |
There was a problem hiding this comment.
Avoid putting detail callbacks in state
When this dynamic variant is copied with STATIC_DETAIL_PARAMS above, the state var contains the get_detail_row_data lambda. Reflex state vars are serialized for the client; arbitrary callables inside a dict are not preserved, so the detail grid loses the callback and expanded rows cannot load. Keep renderer params with JS callbacks as module-level props or rebuild them in the component instead of storing them in rx.State.
Useful? React with 👍 / 👎.
Greptile SummaryThis documentation PR (sixth batch of AI-builder knowledge-base upstreaming) adds two new AG Grid enterprise pages (Tree Data, Master Detail), fixes a
Confidence Score: 5/5Documentation-only changes; no runtime code is modified. Safe to merge. All changes are Markdown documentation and sidebar/title registration. The patterns shown are technically sound and stated to be verified against reflex_enterprise. The only issue found is a minor method-name inconsistency in model-wrapper.md between a pre-existing bullet list and the new code example added in this PR. docs/enterprise/ag_grid/model-wrapper.md — the overridable-methods bullet list uses _get_columns_defs (plural) while the new code example calls _get_column_defs (singular). Important Files Changed
Reviews (2): Last reviewed commit: "ENG: fix master-detail docs: keep callba..." | Re-trigger Greptile |
…odule level, not in state
Sixth batch of upstreaming Reflex Build's AI-builder knowledge base. Enterprise component gaps:
AG Grid
tree_data/get_data_pathFunctionVar pattern, conditional paths, aggregation) and Master-Detail (detail_cell_renderer_paramswithsuccessCallback) — both registered in the sidebarindex.md: selection-changed handler signature (list[dict], and the exact mismatch error a dict signature raises), floating filters, enterprise multi-column filtercell-selection.md: fill-handle modes/direction, per-column suppression, nonexistent-prop pitfallsmodel-wrapper.md: bug fix — docs saidclass_model=, the actual kwarg ismodel_class=(verified against reflex_enterprise); fixed-height requirement,_is_authorizedexamplevalue-transformers.md: formatter patterns and cell renderers (incl. the@rx.memo-via-lambda requirement for interactive renderers)Map: Leaflet icon-options dicts (no
rxe.map.iconexists), map-API pitfalls (function not class, don't store in state, positional args), zoom debounce.React Flow: controlled vs uncontrolled flows, the where-changes-get-applied rule (
apply_node_changesin component wiring, never state code), provider takes no handlers,screen_to_flow_positionusage.Memories already covered by existing pages (pivot mode, basic usage, value getters, editing) were skipped; one memory's unverifiable event-payload claim was rejected. Pre-commit incl. pyright clean.
🤖 Generated with Claude Code