Handle AwaitingApproval status in watch_deployment_status#6797
Handle AwaitingApproval status in watch_deployment_status#6797adhami3310 wants to merge 2 commits into
Conversation
Greptile SummaryThis PR adds handling for the
Confidence Score: 5/5Safe to merge. The change is narrowly scoped to a single polling function, adds a clean exit path for a previously unhandled status, and the loop restructuring is a straightforward improvement. Both changes are small and correct: the new AwaitingApproval branch follows the same break-and-return-True pattern as the existing success branch, and moving time.sleep outside the status-change guard is strictly better behaviour. No existing terminal paths are affected. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "Add changelog fragment" | Re-trigger Greptile |
Merging this PR will not alter performance
Comparing Footnotes
|
What
When watching a hosting deployment, handle the
AwaitingApprovalstatus: report that the build was submitted for approval (and will deploy automatically once approved) and stop watching, rather than looping indefinitely.Also simplifies the status-change loop to only log when the status actually changes.
Why
Deployments that require approval previously never reached a terminal state in
watch_deployment_status, so the CLI would keep polling with no useful feedback.