Conversation
Contributor
|
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend
@rx.memowithby_value,recursive, and a validated JavaScript-safenameoverride. Component memos default to React memoization; Var-returning memos now cache results by argument identity.wrapper=Noneemits a plain component or function, andby_value=Truecomposes with custom wrappers.Packed function signatures (
childrenorRestProp) key the identity cache by sorted prop names and their value identities, so newly allocated transport objects do not cause cache misses. Name validation accepts interior$characters.recursive=Trueenables nested auto-memoization for parameterless component bodies and caller-supplied children. Parameterized bodies currently remain in their enclosing scope to prevent extracted components from referencing unbound parameters. Full parameter capture and forwarding remains follow-up work. Function memos rejectrecursive=True.Includes documentation, changelog fragments, generated stub hashes, regression tests, and compatibility with the current pure-IIFE component output on
main.Validation
uv run --no-sync pyright reflex tests: no errors.Limitations
by_valuecompares serialized values usingJSON.stringify, with its serialization limitations.Type of change