migrate all time env vars to timedelta by benedikt-bartscher · Pull Request #7138 · reflex-dev/reflex

benedikt-bartscher · 2026-09-14T18:30:50Z

follow-up of #7131

…delta

greptile-apps · 2026-09-14T18:34:52Z

Confidence Score: 5/5

The PR appears safe to merge. No new actionable issue remains after the prior review.

What we checked:

SDK logs still reach Reflex: No. bootstrap puts every listed package logger under reflex, and the test checks that records keep flowing upward.
Test code cannot inject commands: No. The test runs one fixed string written in the source. It does not include user, file, network, or environment data.

Summary

Reflex now reads time-based environment variables as timedelta values, so settings can use units like 2m while bare numbers keep their old seconds meaning. Older names still work with one-time migration warnings, and deprecation messages now skip generated and frozen code locations.

Converts database, backend, websocket, reload, disk, and Redis timing settings to duration values.
Keeps old unit-named variables working while directing users to their replacements.
Makes deprecation locations skip generated interpreter frames.

_{Reviews (9) · Last reviewed commit: "Merge branch 'main' into migrate-envvar-..."}

codspeed · 2026-09-14T18:36:50Z

Merging this PR will degrade performance by 3.05%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 52 untouched benchmarks
⏩ 9 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`test_var_access[mutable_dict]`	45.6 ms	47 ms	-3.05%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing benedikt-bartscher:migrate-envvar-timedelta (f513515) with main (bc651dc)}

9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

… default

cubic-dev-ai

No issues found across 13 files

_{Re-trigger cubic}

Review follow-ups for the timedelta migration of the duration env vars: - Treat a blank value as unset, matching EnvVar semantics, so a templated `REFLEX_STATE_MANAGER_DISK_DEBOUNCE=` no longer shadows the old name and a blank old name no longer warns. - Name the exact replacement in the deprecation message (`REFLEX_AUTO_RELOAD_COOLDOWN=5000ms`), since renaming the variable without its unit would silently read the value as seconds. - Warn once per process rather than once per call site, and read the auto-reload cooldown during app setup so its deprecation shows at startup instead of on the first matching frontend error. - Reject a negative opportunistic lock hold time instead of clamping it to one millisecond. - Skip bracketed pseudo-filenames when locating the user frame for a deprecation. A code object with no source file carries `<string>` (exec, a generated dataclass `__init__`) or `<frozen importlib._bootstrap>` rather than a path, and both were reported as the deprecation's location. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gg8XKw3GThDkGC2L4y5ZSH

cubic-dev-ai

All reported issues were addressed across 10 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

- Build the suggested replacement from the parsed value rather than the raw text. A bare int or float accepts forms the duration parser rejects, so `REFLEX_STATE_MANAGER_DISK_DEBOUNCE_SECONDS=.5` suggested `.5s`, which fails to parse. `1_000` and `1e3` had the same problem. - Skip only `<string>` and `<frozen ...>` when locating the user frame for a deprecation, instead of every bracketed name. `<stdin>` and an `<ipython-input-N-...>` cell are real user call sites, and swallowing them pushed the reported location up into the interpreter's own frames. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gg8XKw3GThDkGC2L4y5ZSH

cubic-dev-ai

All reported issues were addressed across 10 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

…delta

migrate all time env vars to timedelta

054eeff

benedikt-bartscher mentioned this pull request Sep 14, 2026

add timedelta env var #7131

Merged

benedikt-bartscher added 2 commits September 14, 2026 20:31

Merge remote-tracking branch 'upstream/main' into migrate-envvar-time…

da1d871

…delta

add news fragments for the duration env var migration

98c5193

greptile-apps Bot reviewed Sep 14, 2026

View reviewed changes

Comment thread reflex/istate/manager/redis.py Outdated

Comment thread reflex/app.py

greptile-apps Bot reviewed Sep 14, 2026

View reviewed changes

Comment thread reflex/istate/manager/redis.py Outdated

round a sub-millisecond oplock hold time up instead of onto the unset…

54d761c

… default

greptile-apps Bot reviewed Sep 14, 2026

View reviewed changes

Comment thread packages/reflex-components-core/src/reflex_components_core/core/banner.py

benedikt-bartscher marked this pull request as ready for review September 14, 2026 18:45

benedikt-bartscher requested a review from a team as a code owner September 14, 2026 18:45

cubic-dev-ai Bot reviewed Sep 14, 2026

View reviewed changes

Merge branch 'main' into migrate-envvar-timedelta

9280eed

masenf reviewed Sep 14, 2026

View reviewed changes

Comment thread packages/reflex-base/src/reflex_base/environment.py Outdated

masenf added 3 commits September 14, 2026 14:03

Update packages/reflex-base/src/reflex_base/environment.py

a3756fc

Update deprecation warning version to 1.0

3187363

Update +envvar-duration-deprecations.feature.md

63349d3

masenf previously approved these changes Sep 14, 2026

View reviewed changes

masenf and others added 2 commits September 14, 2026 15:17

Merge branch 'main' into migrate-envvar-timedelta

b7b276c

masenf mentioned this pull request Sep 15, 2026

Consolidate console.deprecate into the reflex_base.utils.log pipeline #7151

Closed

masenf dismissed their stale review via 3acd82c September 15, 2026 00:38

cubic-dev-ai Bot reviewed Sep 15, 2026

View reviewed changes

Comment thread packages/reflex-base/src/reflex_base/environment.py Outdated

Comment thread packages/reflex-base/src/reflex_base/utils/log.py Outdated

greptile-apps Bot reviewed Sep 15, 2026

View reviewed changes

Comment thread packages/reflex-base/src/reflex_base/utils/console.py Outdated

cubic-dev-ai Bot reviewed Sep 15, 2026

View reviewed changes

Comment thread packages/reflex-base/src/reflex_base/utils/console.py Outdated

benedikt-bartscher and others added 2 commits September 16, 2026 10:08

Merge remote-tracking branch 'upstream/main' into migrate-envvar-time…

c93cef4

…delta

Merge branch 'main' into migrate-envvar-timedelta

f513515

Navigation Menu

migrate all time env vars to timedelta - #7138

migrate all time env vars to timedelta#7138
benedikt-bartscher wants to merge 13 commits into
reflex-dev:mainfrom
benedikt-bartscher:migrate-envvar-timedelta

benedikt-bartscher commented Sep 14, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

greptile-apps Bot commented Sep 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

codspeed Bot commented Sep 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

benedikt-bartscher commented Sep 14, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

Uh oh!

codspeed Bot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 3.05%

Performance Changes

Footnotes

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

benedikt-bartscher commented Sep 14, 2026 •

edited by cubic-dev-ai Bot

Loading

greptile-apps Bot commented Sep 14, 2026 •

edited

Loading

codspeed Bot commented Sep 14, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading