bench: drop flaky isinstance, event handler, and compiler import benchmarks - #7188
Merged
masenf merged 3 commits intoSep 18, 2026
Merged
Conversation
Contributor
|
…hmarks Remove test_isinstance_container[list_dict], test_from_event_type[event_handler], test_get_all_imports and test_collect_imports, whose _complicated_page variants flag noise as regressions. The remaining compile benchmarks still walk imports, and test_import_reflex keeps measuring cold import time.
FarhanAliRaza
force-pushed
the
farhan/remove-flaky-benchmarks
branch
from
September 17, 2026 17:57
7a871ae to
03c5ca2
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
Unrelated PRs (reflex-dev#7175, reflex-dev#7188) moved it by 3-4% in simulation mode. The event param covers the Event pass-through branch and the remaining lambda params cover the lambda unwrapping branch.
It drifted 3-4% on reflex-dev#7175 and reflex-dev#7188 with no event code changed. It is the event_spec path plus one lambda call, which lambda_event_handler already covers.
masenf
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes CodSpeed benchmarks that flag noise as regressions on unrelated PRs.
Removed
test_isinstance_container[list_dict](tests/benchmarks/test_isinstance.py): validated a 10k-elementlist[dict[str, int]]through_isinstance(nested=1). It exercised the same per-element recursion as the remaininglist_int,list_optionalandlist_typeddictparams, so no coverage is lost.test_from_event_type[event_handler](tests/benchmarks/test_event_creation.py): calledEvent.from_event_typewith a bareEventHandler. That path calls the handler to build anEventSpec, which is already covered by theevent_specandlambda_event_handlerparams.test_from_event_type[lambda_event](same file): calledEvent.from_event_typewith a lambda returning an existingEvent. It drifted 3-4% on unrelated PRs (ENG-12486 feat(sdk): log in, review code, and configure cloud providers #7175 and this one). Theeventparam covers the Event pass-through branch andlambda_event_spec/lambda_event_handlercover the lambda unwrapping branch.test_from_event_type[lambda_event_spec](same file): calledEvent.from_event_typewith a lambda returning anEventSpec. It drifted 3-4% on ENG-12486 feat(sdk): log in, review code, and configure cloud providers #7175 and on this PR. It is theevent_specpath plus one lambda call, whichlambda_event_handleralready covers.test_get_all_importsandtest_collect_imports(tests/benchmarks/test_compilation.py): measured import collection alone, once via the legacyComponent._get_all_importsrecursion and once via a plugin walk restricted to imports. Both_complicated_pagevariants drift by several percent between runs.test_compile_pageandtest_compile_all_artifactsstill walk the tree and collect imports as part of the full compile, andtest_import_reflexkeeps measuring coldimport reflextime.The import-only collector plugin in
tests/benchmarks/fixtures.pyhad no other user and is removed with them.Testing
No package source is touched, so this carries
skip-changelog.