Skip to content

docs: use JSON objects for ext-feedback _content parameters#185

Merged
maximelb merged 1 commit intomasterfrom
docs/feedback-content-json-objects
Apr 12, 2026
Merged

docs: use JSON objects for ext-feedback _content parameters#185
maximelb merged 1 commit intomasterfrom
docs/feedback-content-json-objects

Conversation

@maximelb
Copy link
Copy Markdown
Contributor

Summary

  • Update ext-feedback examples to pass approved_content, denied_content, and acknowledged_content as JSON objects instead of JSON-encoded strings
  • Remove json.dumps() wrapper (and unused import json) from the playbook example

Matches the ext-feedback change in 8db6521 that removed the flexJSON unmarshaler.

Test plan

  • Verify mkdocs renders the updated code blocks correctly

🤖 Generated with Claude Code

The ext-feedback extension now expects approved_content, denied_content,
acknowledged_content, and timeout_content as JSON objects instead of
JSON-encoded strings. Update examples accordingly and remove the
now-unnecessary json.dumps() in the playbook example.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@maximelb maximelb requested a review from steveatlc April 12, 2026 01:58
@maximelb maximelb added the to-code-review Used to tag PRs that are force-pushed and will need to be reviewed after the fact. label Apr 12, 2026
@maximelb maximelb marked this pull request as ready for review April 12, 2026 01:58
@maximelb maximelb merged commit 8897b3d into master Apr 12, 2026
2 checks passed
@maximelb maximelb deleted the docs/feedback-content-json-objects branch April 12, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

to-code-review Used to tag PRs that are force-pushed and will need to be reviewed after the fact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant