docs: fix playbook example in ext-feedback#187
Merged
Conversation
…gnature The playbook example used `def main(lc, data)` with a non-existent `lc.extension_request()` method. Playbooks must use `def playbook(sdk, data)` where sdk is a limacharlie.Manager (v4), and `sdk.extensionRequest()` to make extension requests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
maximelb
force-pushed
the
fix/feedback-playbook-example
branch
from
605aefa to
fd41564
Compare
maximelb
added
the
to-code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
def main(lc, data)with a non-existentlc.extension_request()methoddef playbook(sdk, data)signature (ext-playbook looks upglobals['playbook'], notmain)FeedbackSDK class which is the proper way to make feedback requests from a playbookThree bugs fixed
main→playbooklc→sdklc.extension_request(...)→Feedback(sdk).request_simple_approval(...)The companion tutorial (human-in-the-loop-response.md) already uses the correct signature.
🤖 Generated with Claude Code