Skip to content

feat: add feedback CLI commands for ext-feedback#275

Merged
maximelb merged 4 commits intocli-v2from
feedback-cli
Apr 11, 2026
Merged

feat: add feedback CLI commands for ext-feedback#275
maximelb merged 4 commits intocli-v2from
feedback-cli

Conversation

@maximelb
Copy link
Copy Markdown
Contributor

@maximelb maximelb commented Apr 11, 2026

Summary

  • Adds limacharlie feedback command group with CLI commands for the ext-feedback extension
  • SDK class (limacharlie/sdk/feedback.py) wraps extension requests and channel configuration via the extension_config hive
  • CLI commands (limacharlie/commands/feedback.py):
    • feedback request-approval -- send Approve/Deny prompts to a channel
    • feedback request-ack -- send acknowledgement requests
    • feedback request-question -- send free-form text questions
    • feedback channel list/add/remove -- manage channel configuration (web, slack, email, telegram, ms_teams)
  • Responses are dispatched to a case (as a note) or trigger a playbook
  • Timeout support: all three request commands accept --timeout, --timeout-choice (approval only), and --timeout-content to auto-respond after a deadline if no human responds

Test plan

  • All 858 existing CLI regression tests pass (module mapping, command registration, lazy loading, help text)
  • Manual test with a real org: configure a web channel, send an approval request, verify URL is returned
  • Manual test: add/list/remove channels via CLI
  • Manual test: send requests to slack/email/telegram channels with configured Tailored Outputs
  • Manual test: send a request with --timeout and verify auto-response fires after deadline

🤖 Generated with Claude Code

maximelb and others added 4 commits April 10, 2026 20:27
Add dedicated CLI commands for the ext-feedback extension:
- feedback request-approval: send Approve/Deny prompts
- feedback request-ack: send acknowledgement requests
- feedback request-question: send free-form text questions
- feedback channel list/add/remove: manage channel config

Channels support web, slack, email, telegram, and ms_teams types.
Responses are dispatched to a case (as a note) or a playbook.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add --timeout, --timeout-choice, and --timeout-content options to all
three feedback request commands, matching the ext-feedback backend's
new auto-respond-on-timeout feature.

- request-approval: --timeout N --timeout-choice approved|denied
- request-ack: --timeout N (choice is always "acknowledged")
- request-question: --timeout N --timeout-content '...' (content required)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The LC platform expects SchemaDataTypes.JSON fields as JSON-encoded
strings, not raw dicts. The extension's flexJSON unmarshaler handles
both forms, but the platform validates before forwarding.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add explicit Dependencies section showing conditional requirements
- Use \b blocks so Click preserves formatting for examples and lists
- Single-line examples that don't get mangled by Click's text wrapper
- Option help strings explicitly state JSON format with examples
- Channel group help lists all types with their output requirements

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@maximelb maximelb requested a review from dzimine-lc April 11, 2026 15:30
@maximelb maximelb marked this pull request as ready for review April 11, 2026 15:30
@maximelb maximelb merged commit 93f864d into cli-v2 Apr 11, 2026
7 checks passed
@maximelb maximelb deleted the feedback-cli branch April 11, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant