Open
Conversation
…cess, rm continue on err blxr response
add sample command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a method called
send_and_confirm_bxthat handles transaction propegation, mirroring the logic insend_and_confirmas closely as possible along with some enhancements.I've also in my testing process discovered a bug where the program will hang indefinitely if a
minecycle fails.On a failure of the entire sending and confirming cycle, the on chain
proof.last_hash_atwill not update, and so will not be greater than the in memorylast_hash_atbelow:I've fixed this by updating
last_hash_atin theminefunction only if a transaction was succesfully sent, otherwise it will remain at the current difficultly.