Repository navigation
Conversation
…inux via the test-support feature
knoopx
marked this pull request as draft
October 19, 2026 17:20
fdarian
added a commit
to fdarian/gpuix
that referenced
this pull request
Oct 23, 2026
…dow and after setWindowSize (round 15c, remorses#94 window size) FF's check-home-grid failed on a 1512 pt display ("1600px: the viewport container is the window wide: 1512 (expected 1600)") and passed on a 1920 pt one: the check window was clamped to the screen. The remorses#86 commit keeps the test renderer's window frame; this one pins a window wider and taller than the primary display (read through `screen`), at creation and after `setWindowSize`, with its `100vw` x `100vh` box and PNG size at scale 1 and 2. zed's `Window::resize` is exempt from AppKit's screen cap for any window, a live one included (gpuix has no live resize API of its own). Test: react screenshot-scale (11 tests); offscreen-animation-work and font-smoothing pass unchanged; zed gpui_macos window_resize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to get the test renderer working on wayland/linux, so far i managed to compile and run locally, trying to contribute the necessary fixes. This PR is the gpuix crate side, but it also needs the zed changes in remorses/zed#12
tested working on NixOS 26.11 (Zokor) x86_64 / niri 26.04 (Wayland)