Add definitionStyle option to control multi-head goto definition#39
Draft
flowerett wants to merge 1 commit intoremoteoss:mainfrom
Draft
Add definitionStyle option to control multi-head goto definition#39flowerett wants to merge 1 commit intoremoteoss:mainfrom
flowerett wants to merge 1 commit intoremoteoss:mainfrom
Conversation
When a function has multiple heads/clauses, editors like Zed show a picker UI instead of jumping directly.
The new "definitionStyle" initializationOption ("all" or "first") lets users choose whether to return all definition sites or just the first one.
Contributor
Author
|
@JesseHerrick would be great to know your thoughts about this approach and naming. |
Collaborator
|
Hey @flowerett, thanks for the PR! This same thing happens with all editors and LSPs when there are multiple function heads for the same definition with the same arity. IMO that is a feature. While it's something we could change in the LSP, this is something I'd actually leave up to the LSP client and editor to configure to their liking. Editors should be able to just say "give me the first option" instead of opening the list if they want it. In NeoVim this isn't too tricky to configure, but maybe in Zed it's a pain. Thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves this issue
When a function has multiple heads/clauses, editors like Zed show a picker UI instead of jumping directly.
The new "definitionStyle" initializationOption ("all" or "first") lets users choose whether to return all definition sites or just the first one.
the new initializationOption will look like: