Skip to content

feat(onboarding) - add dynamic steps#922

Merged
gabrielseco merged 4 commits intomainfrom
add-dynamic-steps-for-onboarding
Apr 15, 2026
Merged

feat(onboarding) - add dynamic steps#922
gabrielseco merged 4 commits intomainfrom
add-dynamic-steps-for-onboarding

Conversation

@gabrielseco
Copy link
Copy Markdown
Collaborator

@gabrielseco gabrielseco commented Apr 15, 2026

Add dynamic steps like we did in contractor onboarding.

But there's a gotcha to avoid breaking our consumers we have to start using feature flags

I am extracting code from #906, to check little by little the changes


Note

Medium Risk
Changes onboarding step generation and navigation semantics (indices/visibility) behind a new dynamic_steps feature flag, which could break consumers that assume sequential indices or fixed step lists if misused. Adds a new step key placeholder without a backing form yet, increasing integration risk around step rendering and state initialization.

Overview
Adds feature-flagged dynamic onboarding steps via buildSteps, introducing step visible metadata and supporting either legacy sequential indices (default) or preserved original indices including hidden steps when dynamic_steps is enabled.

Updates useOnboarding to derive steps from buildSteps, expands step typing (StepKeys) and wiring (schema map, fields/meta, step value initialization), and exposes a new onboardingBag.steps array for consumers to render navigation.

Updates the example onboarding UI to render step titles/navigation from onboardingBag.steps and enables the dynamic_steps feature in options; adds comprehensive unit tests for buildSteps behavior and extends OnboardingFeatures to include dynamic_steps.

Reviewed by Cursor Bugbot for commit d9eae8e. Bugbot is set up for automated code reviews on this repo. Configure here.

@gabrielseco gabrielseco self-assigned this Apr 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 208.04 kB 207.81 kB +230 B (+0.1%) 🔴
Total (raw) 558.87 kB 558.25 kB +622 B (+0.1%) 🔴
CSS (gzip) 20.11 kB 20.11 kB 0 B (0%) 🟢
CSS (raw) 103.71 kB 103.71 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 208.04 kB / 250 kB (83.2%)
  • ✅ Total raw: 558.87 kB / 600 kB (93.1%)
  • ✅ CSS gzipped: 20.11 kB / 25 kB (80.4%)

Largest Files (Top 5)

  1. chunk-RXNDKUY6.js - 13.83 kB (0 B (0%))
  2. index.css - 10.05 kB (0 B (0%))
  3. styles.css - 10.05 kB (0 B (0%))
  4. index.js - 6.04 kB (-4 B (-0.1%))
  5. chunk-WZE2IQ3A.js - 5.93 kB (new)
View All Files (310 total)
File Size (gzip) Change
chunk-RXNDKUY6.js 13.83 kB 0 B (0%)
index.css 10.05 kB 0 B (0%)
styles.css 10.05 kB 0 B (0%)
index.js 6.04 kB -4 B (-0.1%)
chunk-WZE2IQ3A.js 5.93 kB new
chunk-R47Q7R6C.js 5.82 kB 0 B (0%)
chunk-YZKXKNDS.js 4.4 kB 0 B (0%)
chunk-Y4A7NMBJ.js 4.23 kB new
chunk-HLR7IUW7.js 4.06 kB 0 B (0%)
chunk-3256YUVF.js 3.46 kB new

✅ Bundle size check passed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

Deploy preview for remote-flows-example-app ready!

✅ Preview
https://remote-flows-example-dxdlotnbc-remotecom.vercel.app

Built with commit d9eae8e.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

Deploy preview for remote-flows ready!

✅ Preview
https://remote-flows-qsbqlwr2w-remotecom.vercel.app

Built with commit d9eae8e.
This pull request is being automatically deployed with vercel-action

Comment thread src/flows/Onboarding/utils.ts Outdated
Comment thread src/flows/Onboarding/utils.ts
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

📊 Coverage Report

✅ Coverage increased! 🎉

Metric Current Previous Change Status
Lines 89.94% 89.91% +0.03% 🟢
Statements 89.61% 89.58% +0.03% 🟢
Functions 87.47% 87.40% +0.07% 🟢
Branches 79.78% 79.79% -0.01% 🔴

Detailed Breakdown

Lines Coverage
  • Covered: 3575 / 3975
  • Coverage: 89.94%
  • Change: +0.03% (10 lines)
Statements Coverage
  • Covered: 3638 / 4060
  • Coverage: 89.61%
  • Change: +0.03% (10 statements)
Functions Coverage
  • Covered: 984 / 1125
  • Coverage: 87.47%
  • Change: +0.07% (6 functions)
Branches Coverage
  • Covered: 2217 / 2779
  • Coverage: 79.78%
  • Change: -0.01% (2 branches)

✅ Coverage check passed

Comment thread src/flows/Onboarding/utils.test.ts Outdated
Comment thread example/src/Onboarding.tsx
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d9eae8e. Configure here.

Comment thread src/flows/Onboarding/hooks.tsx
@gabrielseco gabrielseco merged commit e661a6b into main Apr 15, 2026
8 checks passed
@gabrielseco gabrielseco deleted the add-dynamic-steps-for-onboarding branch April 15, 2026 13:14
@gabrielseco gabrielseco mentioned this pull request Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants