Skip to content

Preserve explicit service input during normalization - #75

Open
puncsky wants to merge 1 commit into
render-oss:mainfrom
puncsky:fix/preserve-executable-command-text-20261029
Open

puncsky wants to merge 1 commit into
render-oss:mainfrom
puncsky:fix/preserve-executable-command-text-20261029

Conversation

@puncsky

@puncsky puncsky commented Oct 30, 2026

Copy link
Copy Markdown

Summary

Preserve nonblank build/start/pre-deploy/cron command bytes, and keep explicit blank root/health/pre-deploy overrides long enough to clear clone defaults. Omitted settings retain their existing inheritance behavior.

Motivation

Trimming an escaped trailing space changes the command's argument; normalizing an explicit blank to nil can instead inherit a source setting the caller removed. Both occur at the shared service-input normalization boundary.

How to verify

go test ./cmd/... ./pkg/... ./internal/...
  • All 57 development packages pass on the candidate.
  • Normalizer and real create/update command tests inspect the fake API request bodies for exact command bytes, nil/blank behavior and clone clears across service types. A fresh command factory and a shared fake-create endpoint isolate the command tests.
  • New-code lint is clean against c31e586e; full lint on unmodified main reports 92 pre-existing findings with the pinned golangci-lint v2.14.0.

Release notes

Service commands preserve nonblank executable text, and clones honor explicit blank optional overrides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant