fix: support dict and list[dict] as predictor input types#2928
Merged
markphelps merged 2 commits intomainfrom Apr 10, 2026
Merged
fix: support dict and list[dict] as predictor input types#2928markphelps merged 2 commits intomainfrom
markphelps merged 2 commits intomainfrom
Conversation
dict, Dict[str, Any], list[dict], and List[Dict[str, Any]] were not supported as predictor input types, even though they worked as output types. This broke models using chat-style messages: list[dict] inputs. The fix maps dict types to ANY (opaque JSON objects) in both the Go tree-sitter schema generator (ResolveFieldType) and the Python SDK runtime (FieldType.from_type), handling all variants: bare dict, parameterized Dict[K,V], list[dict], Optional[dict], and PEP 604 union syntax.
|
I'm Bonk, and I've done a quick review of your PR. This PR adds support for LGTM |
The OpenAPI schema serializes property keys in sorted order (items, title, type, x-order), not insertion order. Fix the stdout assertions to match the actual key ordering.
|
I'm Bonk, and I've done a quick review of your PR. This PR adds support for LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dict, Dict[str, Any], list[dict], and List[Dict[str, Any]] were not supported as predictor input types, even though they worked as output types. This broke models using chat-style messages: list[dict] inputs.
The fix maps dict types to ANY (opaque JSON objects) in both the Go tree-sitter schema generator (ResolveFieldType) and the Python SDK runtime (FieldType.from_type), handling all variants: bare dict, parameterized Dict[K,V], list[dict], Optional[dict], and PEP 604 union syntax.