This repository was archived by the owner on May 2, 2024. It is now read-only.
Open
Conversation
anmonteiro
force-pushed
the
anmonteiro/ppxlib
branch
from
971f44d to
1a55362
Compare
|
Would this by any chance have an impact on allowing this library to work on the new m1 chip? My co-worker cannot use this library because of it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts decco to use ppxlib. The conversion is straightforward. I structured it into 2 commits:
Note that, while we're building the PPX with OCaml 4.12, it works well with a current ReScript compiler (on 4.06) – ppxlib does the heavy lifting here. For some more information around that rationale for ppxlib, see this OCaml Discuss topic.