Represent inline record definitions with a type declaration origin - #8686
Merged
cknitt merged 2 commits intoSep 28, 2026
Merged
Conversation
cknitt
marked this pull request as ready for review
September 27, 2026 14:51
cknitt
added this pull request to stack #8683
September 27, 2026 14:55
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## codex/immutable-pexp-attributes #8686 +/- ##
==================================================================
Coverage ? 78.67%
==================================================================
Files ? 476
Lines ? 64402
Branches ? 0
==================================================================
Hits ? 50670
Misses ? 13732
Partials ? 0
🚀 New features to boost your workflow:
|
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
cknitt
force-pushed
the
codex/inline-record-origin
branch
from
September 27, 2026 15:14
14b17f5 to
37d1e7a
Compare
cknitt
force-pushed
the
codex/inline-record-origin
branch
from
September 27, 2026 16:21
37d1e7a to
94ab6c4
Compare
cknitt
force-pushed
the
codex/inline-record-origin
branch
from
September 27, 2026 17:15
94ab6c4 to
e0ae90d
Compare
cknitt
force-pushed
the
codex/inline-record-origin
branch
from
September 27, 2026 17:33
e0ae90d to
f3715fa
Compare
cknitt
force-pushed
the
codex/inline-record-origin
branch
from
September 27, 2026 18:56
f3715fa to
e8411db
Compare
Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>
cknitt
force-pushed
the
codex/inline-record-origin
branch
from
September 27, 2026 20:02
e8411db to
ab2241b
Compare
cristianoc
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ptype_originin the current parsetree, instead of a syntheticres.inlineRecordDefinitionattribute.ptype_originwhen returning to the current AST.Tests
make testmake test-syntax-roundtripmake test-analysisPart of #8624. Stacked on #8685.